fix(protocol-designer): fix time format in load file (#17053)

* fix(protocol-designer): fix time format in load file
Opentrons · Dec 6, 2024 · fd2bab7 · fd2bab7
1 parent eb163e4
commit fd2bab7
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/protocol-designer/fixtures/protocol/8/doItAllV3MigratedToV8.json b/protocol-designer/fixtures/protocol/8/doItAllV3MigratedToV8.json
@@ -143,7 +143,7 @@
           "pauseAction": "untilTime",
           "pauseMessage": "",
           "pauseTemperature": null,
-          "pauseTime": "0:1:2",
+          "pauseTime": "00:01:02",
           "id": "5db07ad0-75c7-11ea-b42f-4b64e50f43e5",
           "stepType": "pause",
           "stepName": "pause",

diff --git a/protocol-designer/fixtures/protocol/8/doItAllV4MigratedToV8.json b/protocol-designer/fixtures/protocol/8/doItAllV4MigratedToV8.json
@@ -184,7 +184,7 @@
           "pauseAction": "untilTime",
           "pauseMessage": "",
           "pauseTemperature": null,
-          "pauseTime": "0:1:2",
+          "pauseTime": "00:01:02",
           "id": "5db07ad0-75c7-11ea-b42f-4b64e50f43e5",
           "stepType": "pause",
           "stepName": "pause",

diff --git a/protocol-designer/fixtures/protocol/8/doItAllV7MigratedToV8.json b/protocol-designer/fixtures/protocol/8/doItAllV7MigratedToV8.json
@@ -251,7 +251,7 @@
           "pauseAction": "untilTime",
           "pauseMessage": "",
           "pauseTemperature": null,
-          "pauseTime": "0:1:0",
+          "pauseTime": "00:01:00",
           "id": "e3989707-210d-457f-a9bb-a85b3ef9b59c",
           "stepType": "pause",
           "stepName": "pause",

diff --git a/protocol-designer/fixtures/protocol/8/example_1_1_0MigratedToV8.json b/protocol-designer/fixtures/protocol/8/example_1_1_0MigratedToV8.json
@@ -176,7 +176,7 @@
           "pauseAction": "untilTime",
           "pauseMessage": "Delay plz",
           "pauseTemperature": null,
-          "pauseTime": "1:2:3",
+          "pauseTime": "01:02:03",
           "id": "2e622080-92a6-11e9-ac62-1b173f839d9e",
           "stepType": "pause",
           "stepName": "pause",

diff --git a/protocol-designer/src/load-file/migration/8_2_0.ts b/protocol-designer/src/load-file/migration/8_2_0.ts
@@ -10,8 +10,11 @@ const getTimeFromIndividualUnits = (
   minutes: any,
   hours?: any
 ): string => {
-  const hoursString = hours !== undefined ? `${hours ?? 0}:` : ''
-  return `${hoursString}${minutes ?? 0}:${seconds ?? 0}`
+  const pad = (num: number): string => String(num).padStart(2, '0')
+  const hoursString = hours !== undefined ? `${pad(Number(hours) ?? 0)}:` : ''
+  return `${hoursString}${pad(Number(minutes) ?? 0)}:${pad(
+    Number(seconds) ?? 0
+  )}`
 }
 
 export const migrateFile = (

diff --git a/protocol-designer/src/steplist/formLevel/stepFormToArgs/test/pauseFormToArgs.test.ts b/protocol-designer/src/steplist/formLevel/stepFormToArgs/test/pauseFormToArgs.test.ts
@@ -56,7 +56,7 @@ describe('pauseFormToArgs', () => {
       pauseAction: PAUSE_UNTIL_TIME,
       description: 'some description',
       pauseMessage: 'some message',
-      pauseTime: '1:20:5',
+      pauseTime: '01:20:05',
     }
     const expected = {
       commandCreatorFnName: 'delay',