Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): only listen to the correct acknowledge messages from CAN #13937

Merged

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Nov 7, 2023

Overview

We should only add the message to the ack queue if the message index matches, so we don't accidentally report the wrong error, like this:

opentrons-api[187176]: Setting gantry load to GantryLoad.HIGH_THROUGHPUT
.... stop request errors .....
opentrons-api[187176]: received error ErrorCode.stop_requested trying to set currents for NodeId.gantry_x

@ahiuchingau ahiuchingau requested a review from a team as a code owner November 7, 2023 20:44
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol whoopsie!

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #13937 (b336207) into edge (d7c25b2) will not change coverage.
Report is 3 commits behind head on edge.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13937   +/-   ##
=======================================
  Coverage   70.62%   70.62%           
=======================================
  Files        2481     2481           
  Lines       69984    69984           
  Branches     8525     8525           
=======================================
  Hits        49426    49426           
  Misses      18465    18465           
  Partials     2093     2093           
Flag Coverage Δ
hardware 56.85% <100.00%> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pentrons_hardware/drivers/can_bus/can_messenger.py 84.76% <100.00%> (ø)

@ahiuchingau ahiuchingau merged commit f9101b4 into edge Nov 7, 2023
@ahiuchingau ahiuchingau deleted the hardware_only-append-to-ack-queue-if-message-index-matches branch November 7, 2023 21:31
ncdiehl11 pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants