Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): let can messenger known what nodes are present #13952

Merged

Conversation

ahiuchingau
Copy link
Contributor

Overview

When we broadcast a CAN message to all the nodes, we are only expecting the basic nodes (X,Y and head) to respond. But now with network info, we do know what devices are present. So we can send over the known (found) nodes to the can messenger whenever we probe the network so our AckListener can actually wait for all present nodes to respond.

@ahiuchingau ahiuchingau requested a review from a team as a code owner November 8, 2023 20:32
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #13952 (66edb85) into edge (3125a8d) will decrease coverage by 0.01%.
Report is 1 commits behind head on edge.
The diff coverage is 37.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13952      +/-   ##
==========================================
- Coverage   70.46%   70.46%   -0.01%     
==========================================
  Files        2511     2511              
  Lines       71194    71201       +7     
  Branches     8952     8952              
==========================================
+ Hits        50165    50169       +4     
- Misses      18849    18852       +3     
  Partials     2180     2180              
Flag Coverage Δ
hardware 56.91% <37.50%> (+<0.01%) ⬆️
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...are/opentrons_hardware/hardware_control/network.py 59.55% <50.00%> (+0.36%) ⬆️
...pentrons_hardware/drivers/can_bus/can_messenger.py 83.72% <33.33%> (-1.05%) ⬇️

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ahiuchingau ahiuchingau force-pushed the hardware_let-can-messenger-known-what-nodes-are-present branch from 53e0a4f to 8f40078 Compare December 4, 2023 17:01
@ahiuchingau ahiuchingau merged commit bf17f63 into edge Dec 4, 2023
17 of 18 checks passed
@ahiuchingau ahiuchingau deleted the hardware_let-can-messenger-known-what-nodes-are-present branch December 4, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants