Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fix origin & target for fast home should not include other axes #13955

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ahiuchingau
Copy link
Contributor

Overview

Forgot to include this in my previous PR #13933, without this, we'd accidentally engage other axes while we're homing one.

@ahiuchingau ahiuchingau requested a review from a team as a code owner November 8, 2023 22:31
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #13955 (66c2a0e) into edge (b895353) will not change coverage.
Report is 2 commits behind head on edge.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13955   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files        2499     2499           
  Lines       70305    70305           
  Branches     8632     8632           
=======================================
  Hits        49739    49739           
  Misses      18476    18476           
  Partials     2090     2090           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/hardware_control/ot3api.py 79.41% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ahiuchingau ahiuchingau merged commit f7e876d into edge Nov 9, 2023
@ahiuchingau ahiuchingau deleted the fix_homing-origins branch November 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants