fix(api): correct logic for simming partial tips #13998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we simulate partial tip pickup we do it by emulating the hardware control logic in the virtual pipette data provider and then passing the result to a nozzle manager the way the hardware controller does. Unfortunately, the logic in the pipette virtual data handler did not match the hardware controller. Until we get to a place where we can have an actual simualting hardware controller or something, we just have to keep these in sync.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13998 +/- ##
==========================================
- Coverage 70.66% 70.66% -0.01%
==========================================
Files 2505 2505
Lines 70869 70869
Branches 8751 8751
==========================================
- Hits 50080 50078 -2
- Misses 18648 18649 +1
- Partials 2141 2142 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Oh awesome! This was giving me trouble in deck conflict check testing too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we simulate partial tip pickup we do it by emulating the hardware control logic in the virtual pipette data provider and then passing the result to a nozzle manager the way the hardware controller does. Unfortunately, the logic in the pipette virtual data handler did not match the hardware controller.
Until we get to a place where we can have an actual simualting hardware controller or something, we just have to keep these in sync.
Testing
This is an analysis-only change, and has no effect on execution. The best way to test it is to test #13972 since that's where I noticed the issue (we'll rebase that PR on this).