-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): throw error if no valid nozzle has tip #15721
Conversation
Provide a check in all LLD functions(called manually or automatically during aspirate) that makes sure that if it's a 96-channel pipette, that at least one of the nozzles with a pressure sensor has a tip on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests please
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
1 similar comment
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts on this pertaining to partial tip:
Do we intend to allow LLD when handling partial tip configurations? Partial tip layouts of our pipettes can result in situations where the tip sensor is not actually covered by the tips we pick up, which could complicate this kind of check. Theres a handful of approaches to take to that problem, the simplest is probably to raise an error if you are attempting LLD with a partially configured pipette. The second case we could attempt is to only ensure we check for tips on the valid nozzles when we are in Full configuration, otherwise don't bother checking.
Long term, we may want an adaptive approach, where we only check for validation if we are in a pipette configuration that should result in tips overlapping with sensors. This would be the most "accurate" approach, but would introduce a double standard for some configurations, but not others.
Maybe fix snapshot testing?
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
The current implementation fixes this I think @CaseyBatten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
Provide a check in all LLD functions(called manually or automatically during aspirate) that makes sure that if it's a 96-channel pipette, that at least one of the nozzles with a pressure sensor has a tip on it.
Overview
Test Plan
Changelog
Review requests
Risk assessment