-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, shared-data): Add liquidProbe command text #15722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command text looks good. Is this command text supposed to be emitted when doing an aspirate with liquid_presence_detection=True
set for the pipette? Because I'm not seeing that. (I also can't get standalone pipette.detect_liquid_presence()
to work but that seems to be a separate bug.)
app/src/molecules/Command/hooks/useCommandTextString/utils/getLiquidProbeCommandText.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me! liquidProbe
and tryLiquidProbe
are supposed to be part of schema 9 right?
My understanding is this is an entirely separate command that is emitted before an aspirate. CC @SyntaxColoring
I'm like 90% sure this is correct but I'll CC @SyntaxColoring just to be safe. |
Yes. The
Yep. |
Closes EXEC-567
Overview
Add new command text for the
liquidProbe
command. I've looked at some similar commands for inspiration.Test Plan
Changelog
liquidProbe
command text.Risk assessment
low