Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components, app): Desktop protocol setup labware list view updates #15726

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Jul 19, 2024

Fix PLAT-385, PLAT-365, PLAT-367, PLAT-368, PLAT-369 ,PLAT-387, PLAT-388

Overview

This PR addresses all of the tickets in the Deck Map Stacking project for the desktop version of protocol setup labware list view
Screen Shot 2024-07-19 at 5 08 09 PM
Screen Shot 2024-07-19 at 5 07 17 PM
Screen Shot 2024-07-19 at 5 05 27 PM
Screen Shot 2024-07-19 at 5 03 10 PM
Screen Shot 2024-07-19 at 5 02 57 PM

Test Plan

Test on both Flex and OT-2, view desktop protocol setup with protocols that labware stacked on top of an adapter and a module, labware that begins off deck, and various module types

Changelog

  1. Added new 'stacked' icon
  2. Adapted display of location column to use LocationIcon for Flex slot names and show the new stacked icon for any labware stacked on an adapter and/or module
  3. Removed "placement" column and moved module information to sit below labware info
  4. Removed the separation of off deck vs on deck labware, including header for "additional off deck labware"
  5. Removed the labware SVG from the list view, add option prob to show the SVG so we can still display that in the off deck list items under labware setup map view
  6. Removed all step numbers from protocol setup
  7. Updated instances of LegacyStyledText to the new system

Review requests

Look over screenshots and designs for alignment -- designs can be found in linked tickets

Risk assessment

Low

@smb2268 smb2268 marked this pull request as ready for review July 19, 2024 21:16
@smb2268 smb2268 requested a review from a team as a code owner July 19, 2024 21:16
@smb2268 smb2268 requested review from mjhuff and removed request for a team July 19, 2024 21:16
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks great!

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@smb2268 smb2268 requested review from brenthagen, ncdiehl11, mjhuff and a team July 22, 2024 15:51
@smb2268 smb2268 merged commit ed5f0ed into edge Jul 22, 2024
34 checks passed
@smb2268 smb2268 deleted the app_protocol-labware-list-view branch July 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants