fix(app): Allow starting protocols on robots with completed runs #15839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is (very) widely used and is better off in a more shared location than having all these places poke into ProtocolUpload
This means that people don't have to make sure to explicitly close the run context by clicking the x button in the post-run flow before picking a new robot to run. Use the current run's completed at timestamp to decide whether or not the run is complete for the purposes of idle. This requires fetching the current run, which we do by ID. Closes EXEC-519
sfoster1
requested review from
smb2268,
shlokamin and
mjhuff
and removed request for
a team
mjhuff
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Sweeeeet! Thanks for tackling this one. Code looks good.
I was concerned about this approach causing a lot of issues with logic contingent upon the run being current and completed, but from my scan of things, I don't think this will be an issue...but we should still test this per your plan in order to confirm, since there are a lot of moving parts here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you click the button to start protocol setup, we try to filter to only robots that are currently capable of starting a protocol. We implemented that as
But, robots don't actually get rid of their current run until a user either clicks the little X button in the run screen on the desktop or goes back to the main screen of the ODD. That doesn't necessarily align with a user's view of "this protocol is done", and so people would think that the robot just disappeared from that little slideout.
To fix this, we should also consider robots that have a completed protocol to be done. This is a small conceptual change and unfortunately a huge pain to implement because data about whether a run is done has to come from getting the state data for that run.
Testing
Closes EXEC-519