Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix various Error Recovery CSS bugs #15859

Merged
merged 9 commits into from
Aug 6, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jul 31, 2024

Closes RQA-2890

Overview

This PR fixes a few of the random CSS issues:

  1. The desktop app shows a scroll bar when the route is a motion type route. The root issue is the use of InProgressModal, which was fixed in another recent PR. There's just some custom sizing to make things look correct now.
  2. The desktop error recovery splash (more like landing) page had the title a bit too high. I've created some shared styles that the DesktopTakeoverModal also utilizes. The nice thing now is that if you look at the splash and then get a takeover modal, the alert icon/text don't visibly shift down on the screen.
  3. When selecting a recovery option on the ODD, the radio buttons were a bit off. Turns out that the RadioButton isLarge style was actually incorrect when looking at it on figma, so I updated that as well.
  4. There was some sizing issues with the Success icon both in Simple Wizard flows and Drop Tip Wiz. I've reverted the success img changes (the root of the problem for Simple Wizard body), and have refactored the Drop Tip Wiz Success component. Yeah, it could be a bit better, but this whole flow is getting a major facelift in 8.1, anyway.

Test Plan and Hands on Testing

  • Verified that the CSS fixes do fix the CSS, and there aren't any (obvious) regressions.
  • Verified the RadioButton changes don't negatively impact anything else in the app.
  • Verified simple wizard flows are fixed and drop tip wiz flows haven't regressed.

Changelog

  • Various style fixes in Error Recovery.

Risk assessment

low

@mjhuff mjhuff requested a review from a team July 31, 2024 19:07
@mjhuff mjhuff requested a review from a team as a code owner July 31, 2024 19:07
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 July 31, 2024 19:07
@mjhuff
Copy link
Contributor Author

mjhuff commented Aug 1, 2024

After in person convo with Seth and PR #15862, we'll ask design to formalize InProgressModal as a component and then apply containers with sizing adjustments around them.

We'll wait to open this PR until after that PR merges.

@mjhuff mjhuff marked this pull request as draft August 1, 2024 13:43
@mjhuff mjhuff changed the base branch from edge to chore_release-8.0.0 August 5, 2024 14:28
@mjhuff mjhuff marked this pull request as ready for review August 5, 2024 17:15
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me!

@mjhuff mjhuff merged commit ba6fadb into chore_release-8.0.0 Aug 6, 2024
43 checks passed
@mjhuff mjhuff deleted the app_er-various-css-fixes branch August 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants