Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): remove enableCsvFile feature flag #15863

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jul 31, 2024

blocked by #15861

closes AUTH-617

Overview

remove enableCsvFile feature flag from app

Test Plan and Hands on Testing

Please check that I properly removed all instances of the feature flag that will no longer be used

Changelog

  • remove enableCsvFile feature flag and translation from app
  • fix affected tests

Risk assessment

low-medium. Most testing has been done with the feature flag enabled.

@ncdiehl11 ncdiehl11 self-assigned this Jul 31, 2024
@ncdiehl11 ncdiehl11 requested review from koji, shlokamin and jerader July 31, 2024 22:44
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 1, 2024 17:01
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 1, 2024 17:01
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thank you for doing this!

@koji koji added the authorship label Aug 2, 2024
@ncdiehl11 ncdiehl11 merged commit 8cdf2b7 into edge Aug 2, 2024
24 checks passed
@ncdiehl11 ncdiehl11 deleted the chore_remove-enablecsvfile-ff branch August 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants