fix(app): filter robots for CSV protocols that raise analysis errors #16145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are intentionally permissive of robots on which to start protocol setup if analysis fails app-side. However, we previously checked whether the analysis contained errors to make this determination. Given that CSV parameter protocols raise analysis errors intentionally, but contain useful information regarding the robot type, we should filter robots if the analysis result is `parameter-value-required`. Closes RQA-3114
ncdiehl11
requested review from
shlokamin and
a team
and removed request for
a team
koji
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We are intentionally permissive of robots on which to start protocol setup if analysis fails app-side. However, we previously checked whether the analysis contained errors to make this determination. Given that CSV parameter protocols raise analysis errors intentionally, but contain useful information regarding the robot type, we should filter robots if the analysis result is
parameter-value-required.Closes RQA-3114
Test Plan and Hands on Testing
Screen.Recording.2024-08-27.at.4.27.09.PM.mov
Changelog
Review requests
Risk assessment
low