fix(protocol-designer): fix Add custom labware button has no hover state #16274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix Add custom labware button has no hover state close RQA-3192
koji
commented
Sep 17, 2024
There was a problem hiding this comment.
the followings are to avoid null-checked issues
jerader
reviewed
Sep 17, 2024
Comment on lines
+479
to
+480
| text-align: ${TYPOGRAPHY.textAlignCenter}; | ||
| display: ${DISPLAY_INLINE_BLOCK}; |
jerader
reviewed
Sep 17, 2024
protocol-designer/src/pages/Designer/DeckSetup/LabwareTools.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Sep 17, 2024
| isSelected: isSelected, | ||
| isLast: isLast, | ||
| moduleModel: def.model, | ||
| text: def?.displayName, |
ncdiehl11
approved these changes
Sep 17, 2024
jerader
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix Add custom labware button has no hover state and spacing in the slideout.
close RQA-3192
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low