Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing lint on release notes #16897

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ecormany
Copy link
Contributor

Overview

Prettier (or whatever runs in our JS lint action) demands a newline after a markdown header. OK.

Test Plan and Hands on Testing

Pass automated tests plz.

Changelog

\n

Review requests

Forgive this shameful and time-wasting PR.

Risk assessment

none

@ecormany ecormany requested a review from a team as a code owner November 19, 2024 23:17
@ecormany ecormany requested review from ncdiehl11 and shlokamin and removed request for a team November 19, 2024 23:17
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 😯

@ecormany ecormany merged commit 1f8e8d4 into chore_release-8.2.0 Nov 19, 2024
36 checks passed
@ecormany ecormany deleted the prettier-has-opinions-on-markdown branch November 19, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants