Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

Merged
merged 9 commits into from
Mar 14, 2025

clean up and fix highlight bug for 8-channel

9f63613
Select commit
Loading
Failed to load commit list.
Merged

feat(protocol-designer, step-generation): single channel partial tip support for 'default' primaryNozzle only #17222

clean up and fix highlight bug for 8-channel
9f63613
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 14, 2025 in 0s

25.53% (+1.17%) compared to a9d6b6f

View this Pull Request on Codecov

25.53% (+1.17%) compared to a9d6b6f

Details

Codecov Report

Attention: Patch coverage is 46.57534% with 117 lines in your changes missing coverage. Please review.

Project coverage is 25.53%. Comparing base (a9d6b6f) to head (9f63613).
Report is 8 commits behind head on edge.

Files with missing lines Patch % Lines
...ol-designer/src/top-selectors/substep-highlight.ts 0.00% 32 Missing ⚠️
...olSteps/StepForm/PipetteFields/PartialTipField.tsx 6.66% 28 Missing ⚠️
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx 0.00% 11 Missing ⚠️
...ner/src/step-forms/utils/createPresavedStepForm.ts 60.00% 10 Missing ⚠️
...components/organisms/Labware/SelectableLabware.tsx 11.11% 8 Missing ⚠️
step-generation/src/utils/safePipetteMovements.ts 80.00% 4 Missing ⚠️
...Tools/MoveLiquidTools/FirstStepMoveLiquidTools.tsx 66.66% 3 Missing ⚠️
...src/pages/Designer/ProtocolSteps/StepForm/utils.ts 0.00% 3 Missing ⚠️
protocol-designer/src/steplist/substepTimeline.ts 0.00% 3 Missing ⚠️
...ration/src/commandCreators/compound/consolidate.ts 72.72% 3 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17222      +/-   ##
==========================================
+ Coverage   24.35%   25.53%   +1.17%     
==========================================
  Files        2949     2949              
  Lines      227263   227356      +93     
  Branches    19137    19456     +319     
==========================================
+ Hits        55354    58044    +2690     
+ Misses     171899   169299    -2600     
- Partials       10       13       +3
Files with missing lines Coverage Δ
components/src/molecules/DropdownMenu/index.tsx 89.72% <ø> (+8.30%) ⬆️
protocol-designer/src/feature-flags/reducers.ts 72.00% <100.00%> (+1.16%) ⬆️
protocol-designer/src/feature-flags/selectors.ts 94.64% <100.00%> (+0.41%) ⬆️
protocol-designer/src/feature-flags/types.ts 100.00% <100.00%> (ø)
...-generation/src/commandCreators/atomic/aspirate.ts 93.61% <100.00%> (+3.87%) ⬆️
...-generation/src/commandCreators/atomic/dispense.ts 91.26% <100.00%> (+4.43%) ⬆️
...generation/src/commandCreators/atomic/pickUpTip.ts 87.93% <100.00%> (+0.21%) ⬆️
...n/src/getNextRobotStateAndWarnings/forPickUpTip.ts 72.22% <100.00%> (ø)
step-generation/src/robotStateSelectors.ts 80.64% <100.00%> (ø)
...eration/src/commandCreators/compound/distribute.ts 94.90% <80.00%> (+3.72%) ⬆️
... and 14 more

... and 91 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov