-
Notifications
You must be signed in to change notification settings - Fork 183
feat(shared-data, api): Add evo tips definition and restrictions on loading #17237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b1f6257
40fe2d9
1b76cad
1a661ce
45cd961
48ba251
d2f9eb7
dac357b
a0e021e
da78ff2
e871be8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ const EXPECTED_VALID_QUIRKS = [ | |
'gripperIncompatible', | ||
'tiprackAdapterFor96Channel', | ||
'stackingMaxFive', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This stackingMaxFive quirk can go away now that its unused in place of the stackLimit and compatibleParentLabware fields. |
||
'stackingOnly', | ||
] | ||
|
||
describe('check quirks for all labware defs', () => { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
"ordering": [], | ||
"brand": { | ||
"brand": "Opentrons", | ||
"brandId": [] | ||
}, | ||
"metadata": { | ||
"displayName": "Evotips adapter", | ||
"displayCategory": "adapter", | ||
"displayVolumeUnits": "\u00b5L", | ||
"tags": [] | ||
}, | ||
"dimensions": { | ||
"xDimension": 156.5, | ||
"yDimension": 105, | ||
"zDimension": 132 | ||
}, | ||
"wells": {}, | ||
"groups": [ | ||
{ | ||
"metadata": {}, | ||
"wells": [] | ||
} | ||
], | ||
"parameters": { | ||
"format": "96Standard", | ||
"quirks": ["tiprackAdapterFor96Channel", "stackingMaxFive"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. stackingMaxFive can be removed here, do we need to add a stackLimit to this labware? It's at the "bottom" of the stack so I think not? |
||
"isTiprack": false, | ||
"isMagneticModuleCompatible": false, | ||
"loadName": "evotips_flex_96_tiprack_adapter" | ||
}, | ||
"namespace": "opentrons", | ||
"version": 1, | ||
"schemaVersion": 2, | ||
"allowedRoles": ["adapter"], | ||
"cornerOffsetFromSlot": { | ||
"x": -14.25, | ||
"y": -3.5, | ||
"z": 0 | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quirk is fine, however theres some parallel work going on with the lids behavior that introduced a new labware parameter called
isDeckSlotCompatible
that could be used for the same thing as this quirk. We'll be using it for the tiprack lids and any other lids that cannot be placed on deck, and in theory could use it here too, although it would need to be updated to apply to regular labware loads as well and not just lid stacks. Not a blocker but eventually we'll probably want to consolidate the two.