fix(abr-testing): fix file upload and error instrument serial number recording #17277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Jan 15, 2025
| model = module_list["model"] | ||
| if model == module_dict[module]: | ||
| error_instrument = module_list["serialNumber"] | ||
| print(f"entered loop {error_instrument}") |
There was a problem hiding this comment.
left in accidentally? notice you removed some prints above
There was a problem hiding this comment.
yes thanks for calling that out
…ons/opentrons into abr-error-recording-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix file upload to jira ticket and give more specific information for error instrument
Test Plan and Hands on Testing
tested on robot
Changelog
ensures just the protocol file is uploaded by moving it into the correct folder and checking that it is a .py file
uses the error node to find the appropriate serial number for errored instrument
Review requests
Risk assessment