-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shared-data): update tipracks to URIs #17288
base: edge
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shrug ... What's the difference between the old tiprack names and the new URIs? (I.e., when would we use one vs the other?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks.
No opinion about hyphens vs. underscores. I don't think underscores are typical in JS, so it'll break somebody's convention no matter what we do.
I think the existing filename doesn't have enough types of word separators:
Compare that to a more sophisticated filename like this, which shows off our word separator capabilities much better:
or the masterpiece
😝😝😝 |
The URIs are the full paths to the definition file of the tiprack. So it's inherently versioned and refer to a very specific instance of a labware definition. The names are not versioned. For the purposes of attaching any specific properties and behavior to a specific tiprack (or any labware if speaking in general terms), it's usually better to use the URIs to categorize instead of names so that if your labware's definition (& hence version) changes, you don't break any existing liquid class behavior. It also allows you to distinguish between an in-built opentrons labware and a same-named custom labware created by the user. |
Closes AUTH-1293
Overview
Replaces the tiprack names with URIs in Ethanol & Glycerol definitions
Review requests
Do we want to rename the
liquid-class
directory toliquid_class
? (dash vs underscore)Risk assessment
None