Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): timeline scrubber to the overview page #17301

Merged
merged 17 commits into from
Jan 29, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 17, 2025

Overview

Some skunkwork that adds the timeline scrubber to PD's overview behind a feature flag.

Test Plan and Hands on Testing

Test out a Flex protocol with the feature flag turned on in pd. see that the timeline scrubber works and generates the steps and visualizes them.

Example protocol you can upload
Bead clean (5).json

Changelog

  • move the load commands into a shared util for PD to use in fileCreator and the scrubber
  • copied the command text json files into pd
  • clean up timeline scrubber props since they were redundant

Risk assessment

low, behind ff

@jerader jerader marked this pull request as ready for review January 17, 2025 17:15
@jerader jerader requested review from a team as code owners January 17, 2025 17:15
@jerader jerader requested review from mjhuff, koji and ncdiehl11 and removed request for a team January 17, 2025 17:15
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a bunch of nits but nothing blocking. looks super cool

@jerader jerader merged commit 16bd893 into edge Jan 29, 2025
59 checks passed
@jerader jerader deleted the pd_timeline-scrubber branch January 29, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants