-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(protocol-designer): start of cypress happy path test for mix settings #17320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thoughtful and thorough test coverage. Once we have alignment on some locators, fix a few bugs, and get Josh's likely much more thorough review it looks good to me!
Actions.SelectTipHandling, | ||
UniversalActions.Snapshot, | ||
Actions.Continue, | ||
Verifications.PartTwoAsp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was really impressed by how thorough your verifications were!
cy.contains(Content.OnceAtStartStep).click() | ||
break | ||
case Actions.AspirateFlowRate: | ||
cy.get(Locators.Aspirate).should('exist').should('be.visible').click() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should work, but I'd want to check with Devs how stable these locators are. I have a decent amount of them in my code as well so would be good to find out!
…age for asp tip pos and delay
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17320 +/- ##
==========================================
- Coverage 26.16% 26.13% -0.04%
==========================================
Files 3191 3195 +4
Lines 230143 230858 +715
Branches 9808 9846 +38
==========================================
+ Hits 60220 60332 +112
- Misses 169898 170501 +603
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
Cypress happy path testing for mix settings. Still in progress, have test cases through Mix Settings Part 2 / 2 Aspirate settings.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment