-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api,shared-data): FlexStacker fixes and improvements to enable ABR/Science. #17350
Conversation
- increased flex stacker z current from 1.5mA to 1.8mA to account for full tipracks - increased the offset used when moving the z axis for storing tall labware like tipracks - added await get_motion_params call when initializing the move_params in the FlexStacker module. - added lid height if lid is used in the retrieve.py and store.py commands. - exclude lids on top of tipracks in the Flex Stacker when getting the highest z. - add flexStackerModuleV1D4 addressable area to the flex stacker + wate chute fixture - adjust the stackingOffsetWithLabware z from 8.193 to 14 for `opentrons_flex_tiprack_lid` - decrease the `gripHeightFromLabwareTop from 8 to 4 for `opentrons_flex_tiprack_lid``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but let's get a constant for that height limit please
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17350 +/- ##
==========================================
+ Coverage 73.84% 79.04% +5.19%
==========================================
Files 43 120 +77
Lines 3304 4586 +1282
==========================================
+ Hits 2440 3625 +1185
- Misses 864 961 +97
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…R/Science. (#17350) - Increased flex stacker z current from 1.5mA to 1.8mA to account for full tipracks - Increased the offset used when moving the z axis for storing tall labware like tipracks - added await get_motion_params call when initializing the move_params in the FlexStacker module. - added lid height if lid is used in the retrieve.py and store.py commands. - exclude lids on top of tipracks in the Flex Stacker when getting the highest z. - add flexStackerModuleV1D4 addressable area to the flex stacker + waste chute fixture - adjust the `stackingOffsetWithLabware` z from 8.193 to 14 for `opentrons_flex_tiprack_lid` - increase the `gripHeightFromLabwareTop` from 8 to 10 for `opentrons_flex_tiprack_lid` - decrease the `gripForce` from 15 to 10 for `opentrons_flex_tiprack_lid`
Overview
Fixes and improvements for the Flex Stacker found while working on setting up ABR.
Test Plan and Hands on Testing
Changelog
opentrons_flex_tiprack_lid
gripHeightFromLabwareTop from 8 to 4 for
opentrons_flex_tiprack_lid``Review requests
am I missing anything?
Risk assessment
Medium, changes lid interactions, needs testing.