Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api,shared-data): FlexStacker fixes and improvements to enable ABR/Science. #17350

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Jan 27, 2025

Overview

Fixes and improvements for the Flex Stacker found while working on setting up ABR.

Test Plan and Hands on Testing

  • Make sure the flex stacker can dispense and retrieve labware and tipracks at full capacity
  • Make sure we can dispense and retrieve tipracks with lids or without lids.
  • Make sure we exclude stacker labware from highest z calculations
  • Make sure we can pickup/dropoff and tiprack lids

Changelog

  • increased flex stacker z current from 1.5mA to 1.8mA to account for full tipracks
  • increased the offset used when moving the z axis for storing tall labware like tipracks
  • added await get_motion_params call when initializing the move_params in the FlexStacker module.
  • added lid height if lid is used in the retrieve.py and store.py commands.
  • exclude lids on top of tipracks in the Flex Stacker when getting the highest z.
  • add flexStackerModuleV1D4 addressable area to the flex stacker + waste chute fixture
  • adjust the stackingOffsetWithLabware z from 8.193 to 14 for opentrons_flex_tiprack_lid
  • decrease the gripHeightFromLabwareTop from 8 to 4 for opentrons_flex_tiprack_lid``

Review requests

am I missing anything?

Risk assessment

Medium, changes lid interactions, needs testing.

- increased flex stacker z current from 1.5mA to 1.8mA to account for full tipracks
- increased the offset used when moving the z axis for storing tall labware like tipracks
- added await get_motion_params call when initializing the move_params in the FlexStacker module.
- added lid height if lid is used in the retrieve.py and store.py commands.
- exclude lids on top of tipracks in the Flex Stacker when getting the highest z.
- add flexStackerModuleV1D4 addressable area to the flex stacker + wate chute fixture
- adjust the stackingOffsetWithLabware z from 8.193 to 14 for `opentrons_flex_tiprack_lid`
- decrease the `gripHeightFromLabwareTop from 8 to 4 for `opentrons_flex_tiprack_lid``
@vegano1 vegano1 requested review from a team as code owners January 27, 2025 13:11
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's get a constant for that height limit please

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (0e7b516) to head (1b544f7).
Report is 44 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17350      +/-   ##
==========================================
+ Coverage   73.84%   79.04%   +5.19%     
==========================================
  Files          43      120      +77     
  Lines        3304     4586    +1282     
==========================================
+ Hits         2440     3625    +1185     
- Misses        864      961      +97     
Flag Coverage Δ
g-code-testing 92.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...a/python/opentrons_shared_data/labware/__init__.py 85.71% <ø> (-1.79%) ⬇️

... and 77 files with indirect coverage changes

@vegano1 vegano1 merged commit 5b91727 into edge Jan 29, 2025
77 checks passed
@vegano1 vegano1 deleted the flex-stacker-fix-lid-height branch January 29, 2025 14:01
caila-marashaj pushed a commit that referenced this pull request Feb 11, 2025
…R/Science. (#17350)

- Increased flex stacker z current from 1.5mA to 1.8mA to account for full tipracks
- Increased the offset used when moving the z axis for storing tall labware like tipracks
- added await get_motion_params call when initializing the move_params in the FlexStacker module.
- added lid height if lid is used in the retrieve.py and store.py commands.
- exclude lids on top of tipracks in the Flex Stacker when getting the highest z.
- add flexStackerModuleV1D4 addressable area to the flex stacker + waste chute fixture
- adjust the `stackingOffsetWithLabware` z from 8.193 to 14 for `opentrons_flex_tiprack_lid`
- increase the `gripHeightFromLabwareTop` from 8 to 10 for `opentrons_flex_tiprack_lid`
- decrease the `gripForce` from 15 to 10 for `opentrons_flex_tiprack_lid`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants