Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Addition of Evotip specific commands #17351

Merged
merged 27 commits into from
Jan 30, 2025
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5b49e05
feat(api): Add the seal command
Laura-Danielle Dec 13, 2024
4ae7f0a
feat(api): Add evotip specific instrument context commands
Laura-Danielle Jan 8, 2025
3a6700e
feat(protocol_engine): Add evotip specific commands to the protocol e…
Laura-Danielle Jan 8, 2025
ce55343
api and core hookup for evotip specific commands
CaseyBatten Jan 22, 2025
299bdf3
context cleanup and parameterization
CaseyBatten Jan 22, 2025
c456ad7
seal command functionality
CaseyBatten Jan 22, 2025
8912d90
update evotip dispense command
Laura-Danielle Jan 23, 2025
477b1c8
update unseal command with correct parameters
Laura-Danielle Jan 23, 2025
7b06608
fix: handle expected stalls in gantry mover
Laura-Danielle Jan 23, 2025
44b4faf
seal command state update and functionality testing
CaseyBatten Jan 23, 2025
ebdfe93
ensure evo tip dispense and unseal functions work
CaseyBatten Jan 24, 2025
4396fa5
papi resin tip command name and doc updates
CaseyBatten Jan 27, 2025
7390be3
default volume and flow rate based on internal evotips testing
CaseyBatten Jan 27, 2025
ba1b3ae
fix naming mismatches in core and engine
Laura-Danielle Jan 29, 2025
8447056
fix test mocks missing new parameters
Laura-Danielle Jan 29, 2025
1689445
Merge branch 'chore_release-8.3.0' into EXEC-907-evotip-specific-comm…
CaseyBatten Jan 29, 2025
4e6c7c7
Engine behavior clean up and removal of unnecessary parameters
CaseyBatten Jan 29, 2025
61da984
pickup and drop offset adjustments as well as test fixture correction
CaseyBatten Jan 29, 2025
1577a5c
evotip seal test cleanup and ignore plunger correction
CaseyBatten Jan 30, 2025
117918f
fixing linter errors
Laura-Danielle Jan 30, 2025
a131b39
Merge branch 'EXEC-907-evotip-specific-commands' of github.com:Opentr…
Laura-Danielle Jan 30, 2025
b1a3619
fix lint and formatting
Laura-Danielle Jan 30, 2025
ee624cf
more linter fixes
Laura-Danielle Jan 30, 2025
2288583
fix evotip dispense test and add movement state
Laura-Danielle Jan 30, 2025
9d17f2d
unseal test cleanup removal of unused pushout command and command sch…
CaseyBatten Jan 30, 2025
343ae3c
hardware testing fixes
CaseyBatten Jan 30, 2025
03110bc
clean up docs ref
CaseyBatten Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hardware testing fixes
CaseyBatten committed Jan 30, 2025
commit 343ae3c1a0770848aed7195374f1f735e89657bd
Original file line number Diff line number Diff line change
@@ -120,7 +120,7 @@ async def _save_result(tag: str, target_z: float, include_pass_fail: bool) -> bo
mount,
Point(z=-Z_AXIS_TRAVEL_DISTANCE),
speed=speed,
_expect_stalls=True,
expect_stalls=True,
)
down_end_passed = await _save_result(
_get_test_tag(current, speed, "down", "end"),
@@ -139,7 +139,7 @@ async def _save_result(tag: str, target_z: float, include_pass_fail: bool) -> bo
mount,
Point(z=Z_AXIS_TRAVEL_DISTANCE),
speed=speed,
_expect_stalls=True,
expect_stalls=True,
)
up_end_passed = await _save_result(
_get_test_tag(current, speed, "up", "end"),
Original file line number Diff line number Diff line change
@@ -201,10 +201,10 @@ async def _test_gripper(api: OT3API, report: CSVReport, section: str) -> None:
target_z = 100
await api.home([z_ax, Axis.G])
start_pos = await api.gantry_position(OT3Mount.GRIPPER)
await api.move_to(mount, start_pos._replace(z=target_z), _expect_stalls=True)
await api.move_to(mount, start_pos._replace(z=target_z), expect_stalls=True)
enc_pos = await api.encoder_current_position_ot3(OT3Mount.GRIPPER)
if abs(enc_pos[Axis.Z_G] - target_z) < 0.25:
await api.move_to(mount, start_pos, _expect_stalls=True)
await api.move_to(mount, start_pos, expect_stalls=True)
if abs(enc_pos[Axis.Z_G] - target_z) < 0.25:
result = CSVResult.PASS
await api.home([z_ax])
Original file line number Diff line number Diff line change
@@ -259,7 +259,7 @@ async def _force_gauge(
mount=mount,
abs_position=press_pos,
speed=FORCE_SPEED,
_expect_stalls=True,
expect_stalls=True,
)
finally:
thread_sensor = False

Unchanged files with check annotations Beta

units?: string
type?: string
}
interface PipetteQuirksField {

Check warning on line 62 in api-client/src/pipettes/types.ts

GitHub Actions / js checks

A record is preferred over an index signature
[quirkId: string]: boolean
}
interface QuirksField {
quirks?: PipetteQuirksField
}
export type PipetteSettingsFieldsMap = QuirksField & {

Check warning on line 69 in api-client/src/pipettes/types.ts

GitHub Actions / js checks

A record is preferred over an index signature
[fieldId: string]: PipetteSettingsField
}
export interface IndividualPipetteSettings {
fields: PipetteSettingsFieldsMap
}
type PipetteSettingsById = Partial<{ [id: string]: IndividualPipetteSettings }>

Check warning on line 77 in api-client/src/pipettes/types.ts

GitHub Actions / js checks

A record is preferred over an index signature
export type PipetteSettings = PipetteSettingsById
export interface PipetteSettingsUpdateFieldsMap {

Check warning on line 81 in api-client/src/pipettes/types.ts

GitHub Actions / js checks

A record is preferred over an index signature
[fieldId: string]: PipetteSettingsUpdateField
}
} | null
export interface UpdatePipetteSettingsData {
fields: { [fieldId: string]: PipetteSettingsUpdateField }

Check warning on line 90 in api-client/src/pipettes/types.ts

GitHub Actions / js checks

A record is preferred over an index signature
}
export interface ResourceLink {
href: string
meta?: Partial<{ [key: string]: string | null | undefined }>

Check warning on line 14 in api-client/src/types.ts

GitHub Actions / js checks

A record is preferred over an index signature
}
export type ResourceLinks = Record<
export const appRestart = (message: string): AppRestartAction => ({
type: APP_RESTART,
payload: {
message: message,

Check warning on line 360 in app-shell-odd/src/actions.ts

GitHub Actions / js checks

Expected property shorthand
},
meta: { shell: true },
})
export const reloadUi = (message: string): ReloadUiAction => ({
type: RELOAD_UI,
payload: {
message: message,

Check warning on line 368 in app-shell-odd/src/actions.ts

GitHub Actions / js checks

Expected property shorthand
},
meta: { shell: true },
})
export const sendLog = (message: string): SendLogAction => ({
type: SEND_LOG,
payload: {
message: message,

Check warning on line 376 in app-shell-odd/src/actions.ts

GitHub Actions / js checks

Expected property shorthand
},
meta: { shell: true },
})
export const updateBrightness = (message: string): UpdateBrightnessAction => ({
type: UPDATE_BRIGHTNESS,
payload: {
message: message,

Check warning on line 384 in app-shell-odd/src/actions.ts

GitHub Actions / js checks

Expected property shorthand
},
meta: { shell: true },
})