Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Use the latest information when estimating liquid height #17374

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

ryanthecoder
Copy link
Contributor

Overview

There was a bug in the estimation code under the following scenario
Well volume is set with Load Liquid
Well is then probed
Well is operated on and the probed volume and loaded volume are updated based on the operation
Future well operations are based on the load liquid and not the probe because it happened to be first in the "is_valid" check

Now the well volume after an operation is based on which happened LAST load_liquid or liquid probe.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner January 28, 2025 21:48
@ryanthecoder ryanthecoder force-pushed the fix-liquid-estimation-source branch from 06c5e62 to c04cf03 Compare January 28, 2025 22:03
@ryanthecoder ryanthecoder force-pushed the fix-liquid-estimation-source branch from c04cf03 to e906c57 Compare January 28, 2025 22:15
Copy link
Contributor

@caila-marashaj caila-marashaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@ryanthecoder ryanthecoder merged commit 2661488 into edge Jan 29, 2025
52 checks passed
caila-marashaj pushed a commit that referenced this pull request Feb 11, 2025
…17374)

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
There was a bug in the estimation code under the following scenario
Well volume is set with Load Liquid
Well is then probed
Well is operated on and the probed volume and loaded volume are updated
based on the operation
Future well operations are based on the load liquid and not the probe
because it happened to be first in the "is_valid" check


Now the well volume after an operation is based on which happened LAST
load_liquid or liquid probe.
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants