Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Stub out flex stacker in deck config #17381

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Jan 29, 2025

Fix EXEC-1087 EXEC-1109

Overview

This PR adds interim support for the stacker and stacker+waste chute in deck config. In later iterations, these will be separated out into a new 4th column instead of also taking up column 3

Test Plan and Hands on Testing

Select D3 on deck configuration for a device with unconfigured stacker, see that you're able to add stacker with or without waste chute
Select A3-C3 and see you're only able to add the stacker
Screenshot 2025-01-29 at 3 15 32 PM
Screenshot 2025-01-29 at 3 15 16 PM
Screenshot 2025-01-29 at 3 16 21 PM

Changelog

  1. Add necessary types for flex stacker fixtures with and without waste chute
  2. Update DeckConfigurator to display flex stacker items
  3. Update AddFixtureModal to display flex stacker for all 3rd column slots, flex stacker and waste chute options for D3

Review requests

Test this out on a bot with an unconfigured stacker

Risk assessment

Low

@smb2268 smb2268 self-assigned this Jan 29, 2025
@smb2268 smb2268 requested a review from a team as a code owner January 29, 2025 20:12
@smb2268 smb2268 requested review from TamarZanzouri and vegano1 and removed request for a team January 29, 2025 20:12
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!
I tested it and it works as expected, thank you!

@smb2268 smb2268 merged commit 8004d59 into edge Jan 29, 2025
60 checks passed
@smb2268 smb2268 deleted the app_flex-stacker-deck-config branch January 29, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants