fix(api): use smaller of max pipette volume and max tip volume for splitting large transfer volumes #17387
+51
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Found a bug in the logic that splits large volume transfers into smaller volumes.
Bug is that we only check the transfer volume against max pipette volume. So if you use a 50uL pipette with a 200uL tip, everything works correctly, but if you use a 1000uL pipette with 50uL tip, it attempts to pipette upto 1000uL, instead of clipping to the max tip volume of 50uL.
This PR fixes that by taking the smaller of pipette volume and tip volume as the max volume a single transfer can take.
Test Plan and Hands on Testing
Unit and integration tests would be enough to catch the error and fix.
Review requests
Check for code sanity
Risk assessment
Low. A scope-limited bug fix