Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer, components) fix deck view size issue #17394

Merged
merged 14 commits into from
Feb 4, 2025
Merged

fix(protocol-designer, components) fix deck view size issue #17394

merged 14 commits into from
Feb 4, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 31, 2025 •
edited
Loading

Overview

update components in Designer to fix deck view size issue

close AUTH-1303 and AUTH-1389

OffDeck screen is still smaller than the design. This will be fixed in the future.
The product team's request is to make bigger the deck view for v8.4.0

Test Plan and Hands on Testing

  • import or create a protocol
  • go to edit protocol page
    check the deck view size in starting deck and protocol step

Changelog

  • update deck view size and layout
  • fix empty state button position in off deck

Review requests

Risk assessment

@koji koji changed the base branch from edge to chore_release-pd-8.4.0 February 3, 2025 17:17
@koji koji marked this pull request as ready for review February 4, 2025 00:27
@koji koji requested review from a team as code owners February 4, 2025 00:27
@koji koji changed the title WIP fix(protocol-designer, components) fix deck view size issue fix(protocol-designer, components) fix deck view size issue Feb 4, 2025
@koji koji removed request for a team February 4, 2025 00:56
ncdiehl11
ncdiehl11 reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Koji— thanks for fixing

@koji koji merged commit e37b61f into chore_release-pd-8.4.0 Feb 4, 2025
36 checks passed
@koji koji deleted the fix_deck-view-size-issue branch February 4, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdiehl11 ncdiehl11 ncdiehl11 approved these changes

@jerader jerader Awaiting requested review from jerader

@syao1226 syao1226 Awaiting requested review from syao1226

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @ncdiehl11