Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add missing usp hub port to a few module display locations #17396

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Jan 31, 2025

Overview

Adding the hubPort field to a few spots where we display a module and fixture location so we can accurately identify which flex stacker is where

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@smb2268 smb2268 requested a review from vegano1 January 31, 2025 16:12
@smb2268 smb2268 self-assigned this Jan 31, 2025
@smb2268 smb2268 marked this pull request as ready for review January 31, 2025 16:28
@smb2268 smb2268 requested a review from a team as a code owner January 31, 2025 16:29
@smb2268 smb2268 requested review from ncdiehl11 and removed request for a team January 31, 2025 16:29
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is great, thank you!

@smb2268 smb2268 changed the title feat(app): Add missing usp hub port to a few fixture locations feat(app): Add missing usp hub port to a few module display locations Jan 31, 2025
@smb2268 smb2268 merged commit 58c9f45 into edge Jan 31, 2025
40 checks passed
@smb2268 smb2268 deleted the app_display-hub-port branch January 31, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants