Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, components): add retract for aspirate and dispense to PD #17411

Open
wants to merge 17 commits into
base: edge
Choose a base branch
from

Update files with the refactored MoveLiquidTools

b152e8c
Select commit
Loading
Failed to load commit list.
Open

feat(protocol-designer, components): add retract for aspirate and dispense to PD #17411

Update files with the refactored MoveLiquidTools
b152e8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 11, 2025 in 0s

27.33% (+1.10%) compared to 731fb9e

View this Pull Request on Codecov

27.33% (+1.10%) compared to 731fb9e

Details

Codecov Report

Attention: Patch coverage is 71.93676% with 71 lines in your changes missing coverage. Please review.

Project coverage is 27.33%. Comparing base (731fb9e) to head (b152e8c).

Files with missing lines Patch % Lines
...s/MoveLiquidTools/MultipleStepsMoveLiquidTools.tsx 0.00% 41 Missing ⚠️
...ocolSteps/StepForm/PipetteFields/PositionField.tsx 0.00% 26 Missing ⚠️
protocol-designer/src/load-file/migration/8_5_0.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17411      +/-   ##
==========================================
+ Coverage   26.23%   27.33%   +1.10%     
==========================================
  Files        3198     3199       +1     
  Lines      231041   231249     +208     
  Branches     9879    10433     +554     
==========================================
+ Hits        60617    63219    +2602     
+ Misses     170399   168001    -2398     
- Partials       25       29       +4
Files with missing lines Coverage Δ
components/src/atoms/ListButton/index.tsx 95.55% <100.00%> (+0.68%) ⬆️
protocol-designer/src/form-types.ts 80.64% <ø> (ø)
...-designer/src/organisms/TipPositionModal/index.tsx 90.47% <100.00%> (+0.03%) ⬆️
...-designer/src/organisms/TipPositionModal/utils.tsx 90.41% <100.00%> (+0.27%) ⬆️
...Form/StepTools/MoveLiquidTools/MultiInputField.tsx 100.00% <100.00%> (ø)
protocol-designer/src/resources/types.ts 100.00% <100.00%> (ø)
...src/step-forms/test/createPresavedStepForm.test.ts 100.00% <100.00%> (ø)
...r/src/steplist/formLevel/getDefaultsForStepType.ts 93.26% <100.00%> (+0.36%) ⬆️
...list/formLevel/test/getDefaultsForStepType.test.ts 100.00% <100.00%> (ø)
...tocol-designer/src/ui/steps/test/selectors.test.ts 100.00% <100.00%> (ø)
... and 3 more

... and 90 files with indirect coverage changes

View more details on Codecov