fix(components): Fix large button outline issue #17415
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LargeButton outline issue for primary type BREAKING CHANGE: 🧨 N ✅ Closes: N
koji
commented
Feb 4, 2025
| @@ -206,7 +206,9 @@ export function LargeButton(props: LargeButtonProps): JSX.Element { | |||
|
|
|||
| border: ${buttonType === 'stroke' | |||
| ? `2px solid ${COLORS.blue55}` | |||
| : `${computedBorderStyle()}`}; | |||
| : buttonType === 'primary' | |||
| ? `4px solid ${COLORS.blue55}` | |||
There was a problem hiding this comment.
using 4px to avoid shrinking
ncdiehl11
approved these changes
Feb 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
LargeButton needs to support stroke button for ODD so need to keep the existing code to avoid having an impact on ODD . This issue will be fixed in the future.
BREAKING CHANGE: 🧨 N
✅ Closes: RQA-3653
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low