-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer, step-generation): update prewet behavior in PD #17433
Conversation
This PR adds prewet to distribute, and updates the logic for when to use prewet for all compound liquid handling command creators. The prewet volume should always be set to the volume of the aspiration that is about to be called (including disposal volume for `distribute`). Prewet commands should be emmitted anytime a new tip is used for an aspiration. Also, I update the UI for the prewet form field in MoveLiquidTools Closes AUTH-908
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17433 +/- ##
==========================================
- Coverage 18.16% 18.15% -0.01%
==========================================
Files 3171 3171
Lines 229418 229466 +48
Branches 6883 6886 +3
==========================================
+ Hits 41665 41669 +4
- Misses 187753 187797 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nice! This would mean a change in behavior for old protocols? lets remember to mention this in the 8.5 announcement modal |
I think the intended behavior for distribute + prewet was missing all along inadvertently. But yes, I will make a note to include this in the 8.5 announcement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Overview
This PR adds prewet to distribute, and updates the logic for when to use prewet for all compound liquid handling command creators. The prewet volume should always be set to the volume of the aspiration that is about to be called (including disposal volume for
distribute
). Prewet commands should be emmitted anytime a new tip is used for an aspiration. Also, I update the UI for the prewet form field in MoveLiquidToolsCloses AUTH-908
Test Plan and Hands on Testing
UI
Step Generation
distribute
command creatorsChangelog
distribute
command creatorReview requests1
Risk assessment
medium. touches
distribute
command creator