Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): various DQA fixes #17440

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 5, 2025

Overview

This PR provides DQA fixes for 8.4.0 alpha.1.

Closes RQA-3929, Closes RQA-3930, Closes RQA-3931, Closes RQA-3933, Closes RQA-3934

Test Plan and Hands on Testing

Timeline Toolbox

  • verify that draggable step names are title-cased
  • in add step overflow menu, verify that step names are title-cased

before:
Screenshot 2025-02-05 at 3 39 12 PM

after:
Screenshot 2025-02-05 at 3 37 10 PM

Absorbance reader toolbox

  • In lid controls, verify that ListButton is correct updated styling (grey20, grey30 for hover). Note that this component is updated across the application according to designs
  • In initialization settings (multi setting), verify that empty selector button for "add wavelength" now has a "+" icon
  • In initialization settings (multi setting), verify that "delete" link has correct style (blue hover)

before:
Screenshot 2025-02-05 at 3 39 52 PM

Screen.Recording.2025-02-05.at.3.40.21.PM.mov

after:
Screenshot 2025-02-05 at 3 37 58 PM

Screen.Recording.2025-02-05.at.3.38.27.PM.mov

Changelog

  • capitalize step names
  • fix "delete" wavelength link
  • fix "add wavelength" button icon
  • fix ListButton style
  • fix tests

Review requests

see test plan

Risk assessment

low

This PR provides DQA fixes for 8.4.0 alpha.1.

Closes RQA-3929, Closes RQA-3930, Closes RQA-3931, Closes RQA-3933, Closes QA-3934
@ncdiehl11 ncdiehl11 self-assigned this Feb 5, 2025
@ncdiehl11 ncdiehl11 requested a review from koji February 5, 2025 20:32
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 5, 2025 20:33
@ncdiehl11 ncdiehl11 requested review from a team as code owners February 5, 2025 20:33
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thank you for fixing them

@ncdiehl11 ncdiehl11 merged commit 9c70e65 into chore_release-pd-8.4.0 Feb 6, 2025
36 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-alpha1-dqa branch February 6, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants