Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, protocol-designer): fix design bugs from PD 8.4.0 alpha.1 #17443

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 5, 2025

Overview

Fix several bugs including

  1. properly displaying labware on absorbance reader in absorbance reader step form module options
  2. removing the 'delete' button from wavelengths if selected insitialization mode is 'single'

Closes RQA-3942, Closes RQA-3945

Test plan

Initialization bug RQA-3942

  • open or create absorbance reader initialization step and select multi mode
  • add several wavelengths, then switch to single mode
  • verify that "delete" button does not render when in single mode

labware bug RQA-3945

  • create or load a protocol with a plate reader and a plate reader-compatible labware
  • create a step to open the plate reader lid
  • create a move step to move the labware into the plate reader
  • create a new plate reader step. inspect module options and verify that both the labware name and the plate reader show (both for single option and multiple options)
Screenshot 2025-02-05 at 5 33 07 PM Screenshot 2025-02-05 at 5 31 57 PM

Changelog

  • fix selector to take in robot state at active item rather than initial deck state for absorbance reader labware
  • fix logic for render 'delete' button for wavelengths

Review requests

see test plan

Risk assessment

low

…ha.1

Fix several bugs including 1) properly displaying labware on absorbance reader in absorbance reader step form module options, and 2) removing the 'delete' button from wavelengths if selected insitialization mode is 'single'

Closes RQA-3942, Closes RQA-3945
@ncdiehl11 ncdiehl11 force-pushed the fix_pd-alpha1-dqa-2 branch from d124e85 to 555831a Compare February 5, 2025 22:38
@ncdiehl11 ncdiehl11 changed the title Fix pd alpha1 dqa 2 fix(components,-protocol-designer): fix design bugs from PD 8.4.0 alpha.1 Feb 5, 2025
@ncdiehl11 ncdiehl11 requested a review from koji February 5, 2025 22:48
@ncdiehl11 ncdiehl11 self-assigned this Feb 5, 2025
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 5, 2025 22:49
@ncdiehl11 ncdiehl11 requested review from a team as code owners February 5, 2025 22:49
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one small comment but lgtm

@ncdiehl11 ncdiehl11 changed the title fix(components,-protocol-designer): fix design bugs from PD 8.4.0 alpha.1 fix(components, protocol-designer): fix design bugs from PD 8.4.0 alpha.1 Feb 6, 2025
@ncdiehl11 ncdiehl11 merged commit 78848e5 into chore_release-pd-8.4.0 Feb 6, 2025
36 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-alpha1-dqa-2 branch February 6, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants