fix(protocol-designer): fix temperature step form

[ncdiehl11]

Overview

This PR fixes a bug in the temperature step form where a form error is incorrecly returned if a user has not entered a temperature, even if the setTemperature ield is set to false. The error arose from incorrectly parsing the string literals for 'true' / 'false'. Also, this PR fixes the step summary text for deactivating a temperature module

Closes RQA-3947, RQA-3948

Test Plan and Hands on Testing

• create or import a protocol with a temperature module
• create a new temperature step
• toggle on 'module state', and enter a value for temperature
• toggle off again, and verify that save works properly
• select or hover that new step, and verify that step summary reads: "[temperature module model] deactivated"

Changelog

• fix temperature required form error logic
• fix step summary ternary condition

Review requests

see test plan

Risk assessment

low

[koji]

thank you for fixing!

[ncdiehl11]

Note, we should probably refactor the implementation of string values where they really should be booleans.

[koji]

Note, we should probably refactor the implementation of string values where they really should be booleans.

you mean update FormData type?