-
Notifications
You must be signed in to change notification settings - Fork 183
feat(engine): consolidate_liquid
engine core implementation
#17458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f4c25c2
first try at consolidate logic
jbleon95 7e011b0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into co…
jbleon95 9ef3682
fixes for a working consolidate
jbleon95 2862106
added integration tests for consolidate
jbleon95 38f8f20
unit test and error raise for blowout location
jbleon95 d97ebae
remove some todos
jbleon95 6a802fe
new volume check to catch errors where air gap or disposal volume for…
jbleon95 6012d02
don't need to check both disposal and air gap volume
jbleon95 b051d71
refactor and correct logic for skipping mix and pre wet and test for it
jbleon95 777c32c
unit test for retract after aspirate consolidate logic
jbleon95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should highlight this and mix, pre-wet behavior in docs. I guess it's okay to raise this error instead of simply skipping the blowout, as long as our built-in classes don't have blowout with source location enabled by default, because otherwise a lot of protocols will run into errors due to no fault of the users. Liquid classes are just supposed to work without having to modify for each transfer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an inventory of the three liquid classes and all have blowout with enabled set to False, with no parameters set. So in order to get this to raise, the user would have to specifically set the location to be
SOURCE
and enable blowout.The reason why I've set this to be an error is that unlike pre-wet or pre-aspirate mix, we're not unconditionally skipping the step, rather we are unable to do one specific combination of settings, and there is no good decision on whether to skip it entirely or change the blowout location, so I'd rather just raise and force the user to decide what change to make if they get themselves in this state.