Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): translate close button text for ODD toasts #17459

Open
wants to merge 1 commit into
base: chore_release-8.3.0
Choose a base branch
from

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Feb 6, 2025

fix RQA-3946

Overview

ODD toasts that pass closeButton=true in props were showing an un-translated "Close". This PR passes the buttonText prop instead, so that the string will be translated

Test Plan and Hands on Testing

Look at one of these toasts on ODD with language as english and Chinese

Screenshot 2025-02-06 at 5 48 56 PM Screenshot 2025-02-06 at 5 48 35 PM

Changelog

Use buttonText instead of closeButton boolean prop

Review requests

Quick code check

Risk assessment

Low

@smb2268 smb2268 self-assigned this Feb 6, 2025
@smb2268 smb2268 marked this pull request as ready for review February 6, 2025 22:49
@smb2268 smb2268 requested a review from a team as a code owner February 6, 2025 22:49
@smb2268 smb2268 requested review from koji, TamarZanzouri, vegano1 and mjhuff and removed request for a team February 6, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant