Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-data,app): Block evotips labware from PD, LL, and Quick Transfer #17460

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Feb 6, 2025

Overview

While evotips is in beta, we don't want it to be visible in PD or LL. We also want to block it from quick transfer since despite it having a display category wellPlate, it does not behave like a normal well plate and isn't compatible with quick transfers

Test Plan and Hands on Testing

Look at quick transfer, ensure evotips lawbare is no longer displayed as an option

Changelog

  1. Add evotips labware to blocklist for PD and LL
  2. Update quick transfer to use the same block list and remove evotips from generated lists of compatible laware

Review requests

Quick code check - I've tested this out

Risk assessment

Low

@smb2268 smb2268 self-assigned this Feb 6, 2025
@smb2268 smb2268 requested a review from a team as a code owner February 6, 2025 23:30
@smb2268 smb2268 requested review from mjhuff, CaseyBatten and jerader and removed request for a team February 6, 2025 23:30
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@smb2268 smb2268 merged commit f0ec5e5 into chore_release-8.3.0 Feb 7, 2025
44 checks passed
@smb2268 smb2268 deleted the shared-data_block-evotips-labware branch February 7, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants