refactor(protocol-designer): initial refactoring of MoveLiquidTools #17470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create new two components to reduce MoveLiquidTools and add basic tests close AUTH-1417
koji
commented
Feb 7, 2025
Comment on lines
+182
to
+241
| <> | ||
| <Divider marginY="0" /> | ||
| <Flex | ||
| flexDirection={DIRECTION_COLUMN} | ||
| gridGap={SPACING.spacing8} | ||
| padding={`0 ${SPACING.spacing16}`} | ||
| > | ||
| <Flex gridGap={SPACING.spacing8} alignItems={ALIGN_CENTER}> | ||
| <StyledText | ||
| desktopStyle="bodyDefaultRegular" | ||
| color={COLORS.grey60} | ||
| > | ||
| {t('protocol_steps:submerge')} | ||
| </StyledText> | ||
| <Flex {...targetProps}> | ||
| <Icon | ||
| name="information" | ||
| size="1rem" | ||
| color={COLORS.grey60} | ||
| data-testid="information_icon" | ||
| /> | ||
| </Flex> | ||
| <Tooltip tooltipProps={tooltipProps}> | ||
| {t(`tooltip:step_fields.defaults.${tab}_submerge`)} | ||
| </Tooltip> | ||
| </Flex> | ||
| <ListItem type="noActive"> | ||
| <Flex | ||
| padding={SPACING.spacing12} | ||
| width="100%" | ||
| flexDirection={DIRECTION_COLUMN} | ||
| gridGap={SPACING.spacing8} | ||
| > | ||
| <InputStepFormField | ||
| showTooltip={false} | ||
| padding="0" | ||
| title={t('protocol_steps:submerge_speed')} | ||
| {...propsForFields[`${tab}_submerge_speed`]} | ||
| units={t('application:units.millimeterPerSec')} | ||
| errorToShow={getFormLevelError( | ||
| `${tab}_submerge_speed`, | ||
| mappedErrorsToField | ||
| )} | ||
| /> | ||
| <InputStepFormField | ||
| showTooltip={false} | ||
| padding="0" | ||
| title={t('protocol_steps:delay_duration')} | ||
| {...propsForFields[`${tab}_submerge_delay_seconds`]} | ||
| units={t('application:units.seconds')} | ||
| errorToShow={getFormLevelError( | ||
| `${tab}_submerge_delay_seconds`, | ||
| mappedErrorsToField | ||
| )} | ||
| /> | ||
| </Flex> | ||
| </ListItem> | ||
| </Flex> | ||
| </> | ||
| ) : null} |
There was a problem hiding this comment.
@ncdiehl11 @syao1226
Do you think we should export this part as LiquidClassesForm something?
or
export these lines as Submerge component and we will add forms for liquid classese?
There was a problem hiding this comment.
Would exporting this part conflict with the new MultiInputField component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://opentrons.slack.com/archives/C07E9T2NAQK/p1738950409218899
close AUTH-1417
Test Plan and Hands on Testing
Changelog
Review requests
low
Risk assessment