Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): recover from stall and an overpressure when dropping tip #17471

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Feb 7, 2025

Overview

closes https://opentrons.atlassian.net/browse/RQA-3935.
catch Overpressure and Stall errors and raise a defined error when dropping tip in order to trigger ER.

Test Plan and Hands on Testing

Run the following protocol on the Flex and try to trigger both stall/overpressue and make sure it triggers ER:

from opentrons import protocol_api

# metadata
metadata = {
    'protocolName': 'drop tip ER',
    'author': 'Opentrons',
    'description': 'drop tip ER',
}
 
requirements = {
    "robotType": "Flex",
    "apiLevel": "2.21",
}

def run(protocol: protocol_api.ProtocolContext):

    #labware
    tiprack1 = protocol.load_labware('opentrons_flex_96_tiprack_1000ul', 'A2')  

    #instruments
    pipette = protocol.load_instrument('flex_8channel_1000', mount = 'left', tip_racks=[tiprack1]) ## will need a modified

     pipette.pick_up_tip()

     protocol.pause("You will have to manually hold tips onto pipette")
     pipette.drop_tip(trashbin)

Changelog

catch exceptions and raise defined errors.

Review requests

changes make sense? retry location makes sense? set fluid state makes sense?

Risk assessment

low.

@TamarZanzouri TamarZanzouri requested review from a team as code owners February 7, 2025 20:39
@TamarZanzouri TamarZanzouri requested review from shlokamin and removed request for a team February 7, 2025 20:39
@TamarZanzouri TamarZanzouri force-pushed the RQA-3935-drop-tip-in-place-stall-overpressure branch from 4de20a4 to 3d2dbea Compare February 7, 2025 20:47
@TamarZanzouri TamarZanzouri requested review from sfoster1 and SyntaxColoring and removed request for shlokamin February 7, 2025 20:48
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.09%. Comparing base (2ec42e1) to head (eadc053).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17471   +/-   ##
=======================================
  Coverage   20.09%   20.09%           
=======================================
  Files        3191     3191           
  Lines      230123   230123           
  Branches     8204     8204           
=======================================
  Hits        46246    46246           
  Misses     183877   183877           
Flag Coverage Δ
protocol-designer 17.41% <ø> (ø)
step-generation 4.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@TamarZanzouri
Copy link
Contributor Author

tested on the robot and works as expected. it triggers ER.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@TamarZanzouri TamarZanzouri force-pushed the RQA-3935-drop-tip-in-place-stall-overpressure branch from cc9d937 to 1ebdba8 Compare February 11, 2025 16:16
@TamarZanzouri TamarZanzouri changed the base branch from edge to chore_release-8.3.0 February 11, 2025 16:16
@TamarZanzouri TamarZanzouri merged commit 4c2e213 into chore_release-8.3.0 Feb 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants