Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add GCodes and to interface with the Time-Of-Flight sensors on the Flex Stacker. #17478

Open
wants to merge 5 commits into
base: edge
Choose a base branch
from

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Feb 10, 2025

Overview

Adds support for interfacing with the TMF8820/21/28 dToF (direct Time Of Flight) sensors for the Flex Stacker, this pull request goes in conjunction with this opentrons-modules pull request Opentrons/opentrons-modules#503.

Adds the following GCodes.

M215 - Get TOF Sensor Status
M222 - Get TOF Driver Register
M223 - Set TOF Driver Register
M224 - Enable TOF Driver

Closes: EXEC-971 EXEC-1166 EXEC-1170 EXEC-1171 EXEC-1172

Test Plan and Hands on Testing

  • Make sure you can get the TOF sensor status for both sensors
  • Make sure you can set and get the registers for each TOF sensor
  • Make sure you can enable/disable the TOF sensor

Changelog

  • add M215 - Get TOF Sensor Status Gcode
  • add M222 - Get TOF Driver Register Gcode
  • add M223 - Set TOF Driver Register Gcode
  • add M224 - Enable TOF Driver Gcode

Risk assessment

Low, unreleased

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

X = "X"
Z = "Z"

def __str__(self) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just make this a StrEnum, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants