fix(protocol-designer): fix OffDeckDetails container flicker #17479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors padding logic in PD OffDeckDetails outer container to align right with padding, rather than dynamically calculating left padding based on the presence of the details element. Closes RQA-3953
jerader
reviewed
Feb 10, 2025
|
ah just realized the responsiveness you have now matches what we have in prod! |
Not a regression but I agree we should make this responsive (maybe X% of the container width) |
koji
reviewed
Feb 10, 2025
protocol-designer/src/pages/Designer/OffDeck/OffDeckDetails.tsx
Outdated
Show resolved
Hide resolved
ncdiehl11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors padding logic in PD
OffDeckDetailsouter container to justify right with padding, rather than justifying center and dynamically calculating left padding based on the presence of the details element. This prevents flickering when hovering an added offdeck labwareCloses RQA-3953
Test Plan and Hands on Testing
Before
Screen.Recording.2025-02-10.at.10.54.26.AM.mov
After
Screen.Recording.2025-02-10.at.10.53.52.AM.mov
Changelog
OffDeckDetailsalignment and paddingReview requests
see test plan
Risk assessment
low