feat(protocol-designer, components): introduce release notes & update react-markdown to v9.0.3 #17481
Conversation
|
|
||
| import styles from './styles.module.css' | ||
|
|
||
| export interface ReleaseNotesProps { | ||
| isOEMMode: boolean |
There was a problem hiding this comment.
preemptively moved this component to components because we might end up displaying it in PD.
| @@ -29,6 +29,14 @@ export default defineConfig( | |||
| configFile: true, | |||
| }, | |||
| }), | |||
| { | |||
| name: 'markdown-loader', | |||
There was a problem hiding this comment.
this is to prepare for displaying the release notes in the announcement modal in pd
jerader
requested review from
koji and
ncdiehl11
and removed request for
a team
|
NOTE: after this PR gets approval from devs, I will follow up with Emily B. to help update the copy in the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17481 +/- ##
==========================================
+ Coverage 18.19% 18.51% +0.32%
==========================================
Files 3175 3182 +7
Lines 229726 231275 +1549
Branches 6910 7315 +405
==========================================
+ Hits 41791 42830 +1039
- Misses 187935 188445 +510
Flags with carried forward coverage won't be shown. Click here to find out more.
|
protocol-designer/src/organisms/AnnouncementModal/announcements.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/RobotSettingsDashboard/RobotSystemVersionModal.tsx
Show resolved
Hide resolved
app/src/organisms/ODD/RobotSettingsDashboard/RobotSystemVersionModal.tsx
Outdated
Show resolved
Hide resolved
jerader
changed the title
|
probably we can add the following to |
closes AUTH-1423
co-authored with @y3rsh
Overview
Introduce release notes to Pd, similarly to what we have in the app and robot releases. I also moved
ReleaseNotesfrom theApptoComponentsbut it is unclear if Pd wants to display the release notes in the announcements modal or just have the link to Github. It seems like we will eventually want to display it in the modal.Additionally,
react-markdownwas updated from v9.0.1 to 9.0.3Test Plan and Hands on Testing
rebuild your dependencies!
Review the code and make sure it makes sense. The link to the release notes.md doc in the announcements modal isn't quite working since it is based off of a github edge link which the doc doesn't exist in edge yet. it should work after this Pr merges.
But you can check how it looks in the branch here: https://github.com/Opentrons/opentrons/blob/07dca99aaee51dc1c40fa7cb4f6317ddbc739750/protocol-designer/release-notes.md
I made sure it looks good in the app still.
Changelog
ReleaseNotesand style sheet out of the app and into componentscomponentsand remove it fromapp.mddoc in protocol-designerRisk assessment
low, merging into edge so there is time to improve it. this is just the foundation. also I will need Emily B. to help write the release notes for 8.5 and probably proofread what i have written so far.