feat(protocol-designer): add declaration for def run() to generated Python
#17482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
reviewed
Feb 10, 2025
Comment on lines
+4
to
+5
| * Our docs call it `protocol`, which is slightly misleading since the object is not | ||
| * the protocol itself, but we'll try to stay consistent with the docs. |
There was a problem hiding this comment.
i agree we should keep consistent even though its misleading. thanks for adding the comment in to explain this!
jerader
approved these changes
Feb 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17482 +/- ##
=======================================
Coverage 26.16% 26.16%
=======================================
Files 3191 3191
Lines 230130 230143 +13
Branches 9807 9808 +1
=======================================
+ Hits 60207 60220 +13
Misses 169898 169898
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
caila-marashaj
pushed a commit
that referenced
this pull request
Feb 11, 2025
… Python (#17482) # Overview This adds the `def run(...)` declaration to the generated Python file. AUTH-1092 We'll start filling in the `run()` function in future PRs. ## Test Plan and Hands on Testing Updated unit tests. Looked at generated file with feature flag turned on. ## Risk assessment Low. This just affects the exported Python file hidden under a feature flag.
TamarZanzouri
pushed a commit
that referenced
this pull request
Feb 11, 2025
… Python (#17482) # Overview This adds the `def run(...)` declaration to the generated Python file. AUTH-1092 We'll start filling in the `run()` function in future PRs. ## Test Plan and Hands on Testing Updated unit tests. Looked at generated file with feature flag turned on. ## Risk assessment Low. This just affects the exported Python file hidden under a feature flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the
def run(...)declaration to the generated Python file. AUTH-1092 We'll start filling in therun()function in future PRs.Test Plan and Hands on Testing
Updated unit tests. Looked at generated file with feature flag turned on.
Risk assessment
Low. This just affects the exported Python file hidden under a feature flag.