Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): fix adding module logic of magnetic block #17485

Merged
merged 3 commits into from
Feb 11, 2025
Merged

fix(protocol-designer): fix adding module logic of magnetic block #17485

merged 3 commits into from
Feb 11, 2025
+28 −9

Conversation

koji
Copy link
Contributor

@koji koji commented Feb 10, 2025

Overview

fix adding module logic of magnetic block
close AUTH-1387

Test Plan and Hands on Testing

test the cases in the ticket

Changelog

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader February 10, 2025 21:16
@koji koji marked this pull request as ready for review February 10, 2025 21:16
@koji koji requested a review from a team as a code owner February 10, 2025 21:16
jerader
jerader approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koji koji merged commit 8ea3427 into chore_release-pd-8.4.0 Feb 11, 2025
14 checks passed
@koji koji deleted the fix_logic-for-magnetic-block branch February 11, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @jerader