feat(shared-data): Update labware schema 3 for new positioning system #17486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-79 and EXEC-81. Changes our labware schema and definitions to implement the new positioning system described in this design document.
Test Plan and Hands on Testing
To do.
Changelog
Schema
dimensions
andcornerOffsetFromSlot
have been replaced by a newextents
object, which has space to list the overall extents (extents.total
) separately from the footprint extents (extents.footprint
), or any other specific things that we might come up with later.locatableFeatures
, which is the crux of the new positioning system.locatingFeatures
too.stackingOffsetWithLabware
andstackingOffsetWithModule
need to be extended to filter by the locating feature in addition to the labware/module load name. When the parent and child are heterogeneous, it's only possible to define a sensible stacking offset in reference to a specific locating feature pairing.Definitions
Other
topLeft
locating feature should be the originfootprint
extent should be wholly contained within thetotal
extentReview requests
Risk assessment