fix(shared-data): Change defaultReturnTipHeight values for 96 channel pipettes #17498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caila-marashaj
changed the title
sfoster1
approved these changes
Feb 11, 2025
sfoster1
added
the
gen-analyses-snapshot-pr
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17500 |
…napshots (#17500) This PR was requested on the PR #17498 Co-authored-by: sfoster1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This closes https://opentrons.atlassian.net/browse/RABR-730.
In shared-data, there's a
defaultReturnTipHeightvalue for every pipette/tip combination that represents what fraction of the tip should be submerged into the tiprack before dropping tips. Previously, this was somewhere between0.6-0.8for everything except 96 channel pipettes, which were0.2.It's possible that this incongruity was an effort to overcome some wonky additional z offset calculation, and this behavior started surfacing recently because of (good) labware offset changes. In any case, we need tips to be somewhere between 60-80% inside the tiprack before dropping them, so let's update that.
I chose
0.71for t1000's because the height for other pipettes' t1000 entries,0.82, was too large and caused the pipette to hit the tiprack adapter pegs, so I went with what seems like the standard for the smaller tips in the single and 8 channels'supportedTips.0.6is known to work on the 96 channel for t20 tips, so I applied to t50 and t200 as well. All of these are tested and look ok on the robot, but let me know if there are other values we should use instead.Review Requests
Which version files should we change?