-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api, shared-data): Module load location refactor for module cutout load and compound fixtures #17499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure of this looks great, thank you!
@@ -133,37 +134,39 @@ async def execute(self, params: LoadModuleParams) -> SuccessData[LoadModuleResul | |||
# addressable areas and deck configurations the same way between OT-2 and Flex. | |||
# Can this be simplified? | |||
if self._state_view.config.robot_type == "OT-2 Standard": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's a deck configuration method that's something like get_deck_supports_cutout_fixtures()
that might be a better call here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17499 +/- ##
==========================================
+ Coverage 26.17% 26.25% +0.08%
==========================================
Files 2838 2799 -39
Lines 217730 215886 -1844
Branches 9280 9268 -12
==========================================
- Hits 56989 56687 -302
+ Misses 160724 159182 -1542
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17547 |
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17547 |
…tor snapshots (#17547) Location sequences now aware of potential fixture that provides them.
Overview
Covers EXEC-1140, RABR-716, EXEC-1106
This PR introduces a engine refactor which will allow modules to "load" at the equipment and substate levels onto addressable areas for OT-2 (directly on the slot) or into cutout IDs for the Flex. It also enhances our location occupation validation logic to allow for more sophisticated checking of Fixtures and labware in regards to slot occupation. It removes custom hard coded logic that skipped the stacker (previously to enable functionality) and now instead supports compound fixtures in real validation (such as Waste chute with Flex Stacker or Magnetic Block with Flex Stacker). This also allows for fixtures, modules and labware to be loaded in any order so long as there would be no physical conflict with the locations referenced in a given load command.
To Do:
get_by_slot(...)
probably needs to be updated to return a list of modules, as we can now have more than one module in a slot...Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
Medium to low - This only touches backend code and not core or API functionality, but we should make sure that no special labware movement or object load rules have had their behavior changed due to this.