-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add and use inStackerHopperLocation #17535
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17535 +/- ##
=======================================
Coverage 63.62% 63.62%
=======================================
Files 2838 2838
Lines 218019 218019
Branches 18107 18107
=======================================
Hits 138704 138704
Misses 79122 79122
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The way it works is you'll store a labware in a hopper, creating one of these new location types with an eventualDestinationSequence
, and then calling retrieve
will update the locations of all the labware in the hopper?
Actually no; the only way you can get this location is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but I think your tests cases that utilize possibleCutoutFixtureIds
are going to start failing if you merge edge in as they do not list all the possibilities? If thats not the case I'll come back and approve.
NotOnDeckLocationSequenceComponent(logicalLocationName=OFF_DECK_LOCATION), | ||
InStackerHopperLocation(moduleId="flex-stacker-id"), | ||
OnCutoutFixtureLocationSequenceComponent( | ||
cutoutId="cutoutB4", possibleCutoutFixtureIds=["flexStackerModuleV1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this need to be updated to include the following (and in all your other tests that list the potential cutout fixtures)?:
"flexStackerModuleV1WithWasteChuteRightAdapterCovered",
"flexStackerModuleV1WithWasteChuteRightAdapterNoCover",
"flexStackerModuleV1WithMagneticBlockV1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh because you merged that other PR? i'll merge edge into this and see if it starts failing
This will be used for labware that is currently located in a stacker hopper as a base, so that OnModuleLocation/OnAddressableAreaLocation can be reserved for labware on the stacker shuttle.
stacker hoppers. Kept you guessing. You don't specify this on the input to loadLabware because very soon you won't be able to load labware into a stacker hopper anymore; once the rest of the commands are implemented, labware will only get this location if it is passed to stacker/store. Closes EXEC-1209
9da89a9
to
47390f0
Compare
Looks like it was just the one test @CaseyBatten , fixed up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stupendiferous
Labware objects that are in the stacker hopper have the new location InStackerHopperLocation, which also identifies the labware Id of the stacker in question.
In this PR, we set the location of labware that get loaded onto the stacker module while static=False to InStackerHopperLocation. However, after the rest of the work in the epic, the only way to get a labware into
InStackerHopperLocation
is to pass it tostacker/store
. It's not a location you can specify in any parameters, which is already true in this PR.Because we're adding it fresh and thus it isn't already serialized anywhere, we can give the location object a
kind
member and therefore don't have to have a separate location sequence component.review requests
does this look like the right data? are we happy with it?
testing
none required, this is well-covered by internal tests and the data that it exposes that changed isn't actually used by anything yet.