feat(api): add setStoredLabware command #17540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17540 +/- ##
=======================================
Coverage 63.62% 63.62%
=======================================
Files 2838 2838
Lines 218019 218019
Branches 18107 18107
=======================================
Hits 138704 138704
Misses 79122 79122
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more. |
vegano1
reviewed
Feb 18, 2025
| self._state_view.labware.get_definition(lid_id), | ||
| labware_defs[0], | ||
| ] | ||
| stack_height = self._state_view.geometry.get_height_of_labware_stack( |
vegano1
reviewed
Feb 18, 2025
| @@ -127,6 +127,39 @@ def __init__( | |||
| or pipette_data_provider.VirtualPipetteDataProvider() | |||
| ) | |||
|
|
|||
| async def load_definition_for_details( | |||
There was a problem hiding this comment.
typo? should be load_definition_FROM_details
There was a problem hiding this comment.
I guess. I read it as "load the definition for the labware with these details". happy to change it if you want me to
vegano1
approved these changes
Feb 18, 2025
sfoster1
added
the
gen-analyses-snapshot-pr
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17541 |
CaseyBatten
approved these changes
Feb 18, 2025
Comment on lines
+148
to
+154
| state_update = ( | ||
| update_types.StateUpdate() | ||
| .update_flex_stacker_labware_pool_definition( | ||
| params.moduleId, labware_def, adapter_def, lid_def | ||
| ) | ||
| .update_flex_stacker_labware_pool_count(params.moduleId, count) | ||
| ) |
Comment on lines
+42
to
+53
| pool_primary_definition = self.pool_primary_definition | ||
| pool_adapter_definition = self.pool_adapter_definition | ||
| pool_lid_definition = self.pool_lid_definition | ||
| if update.pool_constraint != NO_CHANGE: | ||
| pool_primary_definition = update.pool_constraint.primary_definition | ||
| pool_adapter_definition = update.pool_constraint.adapter_definition | ||
| pool_lid_definition = update.pool_constraint.lid_definition | ||
|
|
||
| pool_count = self.pool_count | ||
| if update.pool_count != NO_CHANGE: | ||
| pool_count = update.pool_count | ||
|
|
sfoster1
force-pushed
the
exec-1209-in-stacker-hopper-location
branch
from
9da89a9 to
47390f0
Compare
Base automatically changed from
exec-1209-in-stacker-hopper-location
to
edge
February 19, 2025 16:01
Adds the new setStoredLabware command to constrain the flex stacker labware pool. Closes EXEC-1212
sfoster1
force-pushed
the
exec-1212-set-stored-labware-pe
branch
from
4f0c5c3 to
097d92f
Compare
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17552 |
…snapshots (#17552) This PR was requested on the PR #17540 Co-authored-by: sfoster1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new setStoredLabware command to constrain the flex stacker labware pool.
The idea here is that you configure each stacker with some concept of "this is the kind of labware you contain", and an amount of labware. Then, you update how much it contains and when you retrieve stuff
retrievecreates a new labware object. Only labware that entered the stacker throughstoreretains its individuality.This PR creates the command and adds the new data to the stacker substate, but it's not yet used for anything; static mode remains, loading labware objects into the hopper remains. In followup prs, we'll remove that older loading capability, and switch things over to using the new way of doing things.
testing
reviews
Closes EXEC-1212