fix(protocol-designer,-shared-data): update command schema to v10 #17548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an oversight, PD 8.4.0 maintained exporting protocols with command schema v8. This PR updates the command schema to v10.
shlokamin
reviewed
Feb 18, 2025
| @@ -115,7 +120,7 @@ export type ProtocolFile< | |||
| (OT2RobotMixin | OT3RobotMixin) & | |||
| LabwareV2Mixin & | |||
| LiquidV1Mixin & | |||
| (CommandV8Mixin | CommandV9Mixin) & | |||
| (CommandV8Mixin | CommandV9Mixin | CommandV10Mixin) & | |||
There was a problem hiding this comment.
should this not just be CommandV10Mixin?
There was a problem hiding this comment.
nvm this is fine for now. we should change this but we first gotta change the interfaces of the migration files in PD so they return more granular interfaces
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.4.2 #17548 +/- ##
=======================================================
Coverage 24.77% 24.77%
=======================================================
Files 2838 2838
Lines 217841 217841
Branches 9284 9284
=======================================================
Hits 53975 53975
Misses 163852 163852
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shlokamin
approved these changes
Feb 18, 2025
|
targeted correct 8.4.2 release branch and closed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As an oversight, PD 8.4.0 maintained exporting protocols with command schema v8. This PR updates the command schema to v10.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low-med