Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add stacker fill, empy, set_stored_labware #17570

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Feb 21, 2025

Add a protocol API binding for fill, empty, and set_stored_labware.
These functions are used to configure the stacker labware pool and to
empty or fill the hopper interactively while a protocol is paused.

Also, add tests and a slight defaulting change to the engine setStoredLabware command.

testing

  • run a protocol and test that fill, empty, and set_stored_labware run

Closes EXEC-1217
Closes EXEC-1216

Whoops. Also, allow count to default.
Add a protocol API binding for fill, empty, and set_stored_labware.
These functions are used to configure the stacker labware pool and to
empty or fill the hopper interactively while a protocol is paused.

Closes EXEC-1217
Closes EXEC-1216
@sfoster1 sfoster1 requested review from a team as code owners February 21, 2025 18:40
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.63%. Comparing base (4dd87df) to head (a4a172a).
Report is 11 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17570       +/-   ##
===========================================
- Coverage   63.46%   25.63%   -37.83%     
===========================================
  Files        2840     2840               
  Lines      218462   218472       +10     
  Branches    18140    17943      -197     
===========================================
- Hits       138640    56012    -82628     
- Misses      79629   162445    +82816     
+ Partials      193       15      -178     
Flag Coverage Δ
app 3.42% <ø> (-43.21%) ⬇️
protocol-designer 18.85% <ø> (ø)
shared-data 74.34% <ø> (+71.84%) ⬆️
step-generation 4.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1538 files with indirect coverage changes

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Comment on lines +759 to +767
main_load_name: str,
main_namespace: str | None,
main_version: int | None,
lid_load_name: str | None,
lid_namespace: str | None,
lid_version: int | None,
adapter_load_name: str | None,
adapter_namespace: str | None,
adapter_version: int | None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh nice I was wondering where these would come in. Makes sense, this'll play nicely with how retrieve is loading the labware data.

@sfoster1 sfoster1 merged commit 477ed2f into edge Feb 21, 2025
71 of 72 checks passed
@sfoster1 sfoster1 deleted the exec-1217-api-fill-empty-set-stored branch February 21, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants