-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add stacker fill, empy, set_stored_labware #17570
Conversation
Whoops. Also, allow count to default.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17570 +/- ##
===========================================
- Coverage 63.46% 25.63% -37.83%
===========================================
Files 2840 2840
Lines 218462 218472 +10
Branches 18140 17943 -197
===========================================
- Hits 138640 56012 -82628
- Misses 79629 162445 +82816
+ Partials 193 15 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
main_load_name: str, | ||
main_namespace: str | None, | ||
main_version: int | None, | ||
lid_load_name: str | None, | ||
lid_namespace: str | None, | ||
lid_version: int | None, | ||
adapter_load_name: str | None, | ||
adapter_namespace: str | None, | ||
adapter_version: int | None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh nice I was wondering where these would come in. Makes sense, this'll play nicely with how retrieve is loading the labware data.
Add a protocol API binding for fill, empty, and set_stored_labware.
These functions are used to configure the stacker labware pool and to
empty or fill the hopper interactively while a protocol is paused.
Also, add tests and a slight defaulting change to the engine setStoredLabware command.
testing
Closes EXEC-1217
Closes EXEC-1216